Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config\default.json generated without callbackURL config needed to set redirect URL for Google Outh2 #669

Closed
HarisHashim opened this Issue Apr 20, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@HarisHashim
Copy link

HarisHashim commented Apr 20, 2018

Steps to reproduce

Do "feathers generate authentication" and choose Google oauth

config\default.json should have this for Google

"google": { "clientID": "xxxx", "clientSecret": "xxxx", "successRedirect": "/auth", "scope": [ "profile openid email" ] }

  • I need to change as bellow to change redirect URL. Otherwise I always get http://localhost:8080/auth/google/callback as redirect URL.

    "successRedirect": "http://aaa.bbb.cc/",
    to 
    "callbackURL": "http://aaa.bbb.cc/",
    

Expected behavior

It looks like that successRedirect should be callbackURL. Something must have change!

NodeJS version: v6.11.2

Operating System: Ubuntu

Browser Version: Chrome Version 64.0.3282.140 (Official Build) (32-bit)

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Apr 20, 2018

The idea is that you will be setting your host option properly in other environments (e.g. NODE_ENV=production).

@daffl daffl closed this Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.