Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled hooks should pull from auth config to avoid having to pass duplicate props. #93

Closed
ghost opened this Issue Mar 3, 2016 · 4 comments

Comments

Projects
None yet
1 participant
@ghost
Copy link

ghost commented Mar 3, 2016

I runned into an issue @feathersjs-ecosystem/feathers-react-native-chat#5

As I learned I had to set the config for auth to use id instead of _id when using pg, via :

"auth": { "idField" : "id" }

Howerver using hook still require to set the correct id :

create: [auth.setUserId({sourceProp:'id',destProp: 'sentBy'})]

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Mar 3, 2016

So it's not working for you with those changes?

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Mar 3, 2016

It's work if I set the sourceProp, but as I already set the config it should take care itself.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Mar 3, 2016

Ah I get it! Ya I think @harangue made the same observation. I'm going to rephrase the issue title.

@ekryski ekryski changed the title Hooks source ID using pg Bundled hooks should pull from auth config to avoid having to pass duplicate props. Mar 3, 2016

@ekryski ekryski modified the milestone: 1.0 release Mar 19, 2016

@ekryski ekryski referenced this issue Mar 21, 2016

Merged

v0.6 - Bugs fixes, new hooks, and hook tests #109

10 of 10 tasks complete
@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Mar 24, 2016

Closed in v0.6.0 by #109.

@ekryski ekryski closed this Mar 24, 2016

@ekryski ekryski modified the milestones: 1.0, 0.6 Mar 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.