Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primus client connect event is 'open' #106

Merged
merged 1 commit into from Mar 16, 2016

Conversation

Projects
None yet
3 participants
@ahdinosaur
Copy link
Contributor

ahdinosaur commented Mar 16, 2016

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Mar 16, 2016

Thank you! I was wondering about that actually. Do you have an idea why the Primus tests was passing before?

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Mar 16, 2016

@ahdinosaur good catch. I totally missed that when I review the PR. That's weird that those tests were passing. We'll need to look at that. This is good to merge though.

ekryski added a commit that referenced this pull request Mar 16, 2016

Merge pull request #106 from ahdinosaur/fix-primus-connected
primus client connect event is 'open'

@ekryski ekryski merged commit f25dcde into feathersjs:master Mar 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ahdinosaur

This comment has been minimized.

Copy link
Contributor Author

ahdinosaur commented Mar 16, 2016

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Mar 16, 2016

Oh. Haha, well that'll do it. I thought it was timing out but it was totally a workaround for that bug. I'm pretty sure we can take that out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.