Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue where next is called twice when hitting an unauthenticated service via socket.io #18

Merged
merged 4 commits into from Dec 20, 2015

Conversation

Projects
None yet
2 participants
@corymsmith
Copy link
Contributor

corymsmith commented Dec 18, 2015

This fixes #17 and fixes up some intermittently failing tests.

corymsmith added some commits Dec 18, 2015

Moving REST tests for valid auth token tests out to separate test sui…
…te and increasing timeout to fix intermittent test failures
@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Dec 18, 2015

It looks like the build is failing when trying to install the bcrypt module. It looks like it's attempting on NodeJS version 5: https://travis-ci.org/feathersjs/feathers-authentication/jobs/97692661#L2823

Maybe that module hasn't been updated to work with Node v5. Want to try setting up the travis.yml to use Node v4.2.2?

@corymsmith

This comment has been minimized.

Copy link
Contributor Author

corymsmith commented Dec 18, 2015

Still fails on bcrypt, buffer-util and utf-8-validate modules. The same thing happened with my documentation change earlier this week.

marshallswain added a commit that referenced this pull request Dec 20, 2015

Merge pull request #18 from corymsmith/master
Fixing issue where next is called twice when hitting an unauthenticated service via socket.io

@marshallswain marshallswain merged commit 1633918 into feathersjs:master Dec 20, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.