Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring to simplify structure and remove code duplication #209

Merged
merged 1 commit into from May 18, 2016

Conversation

Projects
None yet
2 participants
@daffl
Copy link
Member

daffl commented May 18, 2016

I went through the code to refresh my memory and made some small tweaks for organization (move lonely index.js files in the services folder one level up), split the middleware file into one for Express and one for websockets and refactored the code duplication out of the websocket authentication handlers.

I don't think anything controversial but @ekryski should definitely double check.

@daffl daffl added the in progress label May 18, 2016

@daffl daffl force-pushed the small-refactoring branch from 33241b2 to 2fc1f5e May 18, 2016

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented May 18, 2016

This is great! Stuff I had been wanting to do but hadn't had time. Thanks @daffl!

@ekryski ekryski merged commit e41e09e into master May 18, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl removed the in progress label May 18, 2016

@daffl daffl deleted the small-refactoring branch Aug 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.