Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrictToOwner -Fix check for methodNotAllowed #335

Merged
merged 4 commits into from Oct 28, 2016

Conversation

Projects
None yet
2 participants
@daffl
Copy link
Member

daffl commented Oct 28, 2016

Closes #332, closes #319

aengushearne and others added some commits Oct 26, 2016

restrictToOwner -Fix check for methodNotAllowed
methodNotAllowed was being checked as "if (!hook.id)", leading to erroneous or misleading error messages.
Changed to check against hook.method 

This also fixes #319.
Update restrict-to-owner.js
Fix works but integration test failure, trying alternative syntax.

@daffl daffl merged commit 875bbe4 into master Oct 28, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the restrict-to-owner branch Oct 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.