Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing redirect middleware #353

Merged
merged 1 commit into from Nov 25, 2016

Conversation

Projects
None yet
1 participant
@ekryski
Copy link
Member

ekryski commented Nov 25, 2016

Summary

Express redirect middleware were not actually redirecting because of 2 things:

  • the hook object lives on res.hook not req.hook
  • if the hook object is previously modified the modifications weren't passed along. Only modified hook.data gets passed along to express middleware.

@ekryski ekryski merged commit 56af813 into master Nov 25, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ekryski ekryski deleted the fix-redirects branch Nov 25, 2016

@ekryski

This comment has been minimized.

Copy link
Member Author

ekryski commented Nov 25, 2016

released in 1.0.0-beta-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.