Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow runtime auth via socket.io #4

Merged
merged 2 commits into from Nov 16, 2015

Conversation

Projects
None yet
2 participants
@randomnerd
Copy link

randomnerd commented Nov 16, 2015

you can see this functionality being used at my feathers-react-postgres demo here: https://github.com/randomnerd/feathers-react-pg

Random Nerd added some commits Nov 16, 2015

Random Nerd
Random Nerd
fix
@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Nov 16, 2015

Can you please set the main back to the lib folder? The module uses ES6, now, so Babel builds the main folder upon install.

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Nov 16, 2015

I'm going to merge this and fix it.

marshallswain added a commit that referenced this pull request Nov 16, 2015

Merge pull request #4 from randomnerd/patch-1
allow runtime auth via socket.io

@marshallswain marshallswain merged commit 7affdb7 into feathersjs:master Nov 16, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@randomnerd

This comment has been minimized.

Copy link
Author

randomnerd commented Nov 16, 2015

how do you use the package then? when i install it there is no lib folder so it doesnt work

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Nov 16, 2015

I’m not sure what’s wrong. What’s your node --version and your npm --version?
I’m running npm 2.14.7 and node 4.2.2.

I guess it’s possible that I’ve misunderstood how it’s supposed to work, but the other repos that have moved to ES6 don’t have a lib folder: https://github.com/feathersjs/feathers-knex https://github.com/feathersjs/feathers-knex

The scripts in the package.json show the compile commands that should be running. Maybe we’re missing a “postinstall" script. You should be able to cd into the folder and do npm run compile until we get it sorted out.

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Nov 16, 2015

Ok. Looks like I didn't understand completely. It gets compiled on publish so that babel can stay as a devDependency. I've published 0.0.2. Also, I've added a few issues to the 1.0 milestone. If you feel like you can pitch in some more that would be awesome. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.