Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent setCookie from mutating authOptions #414

Merged
merged 1 commit into from Feb 7, 2017

Conversation

Projects
None yet
2 participants
@adrien-k
Copy link
Contributor

adrien-k commented Feb 6, 2017

setCookie is mutating authOptions, setting a constant value for expires attribute which is then re-used on every further setCookie calls.

After a while, cookies are sent already-expired...this PR should fix it (is it a proper way to do it ?).

Thanks for this awesome framework !

@daffl daffl merged commit dcdc258 into feathersjs:master Feb 7, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@daffl

This comment has been minimized.

Copy link
Member

daffl commented Feb 7, 2017

Thank you for the fix and for the test! We'll release it shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.