Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatible version of the original compile comand with public folder support. #442

Merged
merged 3 commits into from Mar 10, 2017

Conversation

Projects
None yet
2 participants
@appurist
Copy link
Contributor

appurist commented Mar 10, 2017

  • In the legacy branch, the npm run compile command was:
rm -rf lib/ && babel -d lib/ src/ && mkdir lib/public/ && cp src/public/* lib/public/

But that wasn't windows compatible. Two problems: forward slashes on the mkdir and cp commands cause parameter errors, and missing the cp command on Windows. Although rimraf takes care of the first half, I suspect the public copy was lost because a cross-platform recursive mkdir+cp is hard to find. But it turns out that babel -D handles that.

  • Also fixed the extra -rf that should not be used with rimraf.
  • Also added .idea and .vs Windows IDE user folders to .gitignore file.

appurist added some commits Mar 10, 2017

Windows compatible version of the original compile comand with public…
… folder support.

- Was `"rm -rf lib/ && babel -d lib/ src/ && mkdir lib/public/ && cp
src/public/* lib/public/"` in legacy but that wasn't windows compatible.
Although `rimraf` takes care of the first half, I suspect the public
copy was lost because a recursive mkdir+cp is hard to find. But `babel
-D` handles that.
- Also fixed the extra `-rf` that should not be used with `rimraf`.
@daffl

This comment has been minimized.

Copy link
Member

daffl commented Mar 10, 2017

Thank you! I thought we got them all. Why do we have to copy a public folder? I can't see one in master.

@daffl daffl merged commit 15b49d1 into feathersjs:master Mar 10, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.