Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out all events #461

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Projects
None yet
3 participants
@daffl
Copy link
Member

daffl commented Mar 23, 2017

Closes #460

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Mar 23, 2017

Looks good. Do you think we need to pad the timing a little bit to make sure there has been enough time for an event to occur before it calls done()? Theoretically, it should have enough time since we're also verifying the JWT.

@daffl

This comment has been minimized.

Copy link
Member Author

daffl commented Mar 23, 2017

Mocha will just complain that done was called twice without this fix.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Mar 23, 2017

:shipit:

@daffl daffl merged commit 8a7f3c7 into master Mar 23, 2017

4 checks passed

codeclimate no new or fixed issues
Details
codeclimate/coverage 84.43% (+0.1%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the filter-events branch Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.