Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #475 - Socket params are made available to authentication hooks #477

Merged
merged 1 commit into from Apr 11, 2017

Conversation

Projects
None yet
3 participants
@thomas-p-wilson
Copy link
Contributor

thomas-p-wilson commented Apr 9, 2017

Makes those parameters specified in socket.feathers.data or req.feathers.data, when setting up SocketIO and Primus respectively, available to the authentication hooks as they would be elsewhere in a Feathers application.

Resolves #475

Resolves #475 - Socket params are made available to authentication hooks
Makes those parameters specified in `socket.feathers.data` or `req.feathers.data`, when setting up SocketIO and Primus respectively, available to the authentication hooks as they would be elsewhere in a Feathers application.
@daffl

This comment has been minimized.

Copy link
Member

daffl commented Apr 10, 2017

Took a quick look and this looks good to me (also, thank you for the tests!). I'll let @ekryski have another eye on this before merging.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Apr 11, 2017

Yup this looks good. Can't see/think of any adverse side-effects. Thanks for the great PR @thomas-p-wilson!

@ekryski ekryski merged commit 9b0d0a3 into feathersjs:master Apr 11, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@thomas-p-wilson

This comment has been minimized.

Copy link
Contributor Author

thomas-p-wilson commented Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.