Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with very large token timeout. #499

Merged
merged 2 commits into from May 10, 2017

Conversation

Projects
None yet
4 participants
@asdacap
Copy link
Contributor

asdacap commented May 8, 2017

Summary

Fix the socket authentication immediately logout when setting a very large token expiry time. See #458. This is likely due to 32bit integer overflow in setTimeout. It overcome this issue by using the long-timout npm package.

@daffl

This comment has been minimized.

Copy link
Member

daffl commented May 9, 2017

This looks good to me, thank you! Once @ekryski or @marshallswain give the ok we'll release it.

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented May 9, 2017

Please :shipit:

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented May 10, 2017

This looks great! Thanks @asdacap! ❤️

@ekryski ekryski merged commit 224c040 into feathersjs:master May 10, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.