Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default authentication config keys #506

Merged
merged 5 commits into from Jun 8, 2017

Conversation

Projects
None yet
2 participants
@ekryski
Copy link
Member

ekryski commented May 10, 2017

Summary

The default config key was changed to authentication and was not updated here. This fixes that. This isn't a breaking change for anyone using v2 of the generator and/or are passing their auth config explicitly when configuring auth plugins:

const config = app.get('auth');
app.configure(authentication(config));

but it will be for people that migrated to the new version of auth and still have a config file with:

"auth": {
   // auth config values
}

instead of:

"authentication": {
   // auth config values
}

For that reason, this and the associated PRs will need to be major releases:

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented May 10, 2017

Why not ease the burden with a var authConfig = app.get('auth') || app.get('authentication') and merge that in, instead? We'll have some cleanup work to do as tech support, otherwise.

@ekryski ekryski referenced this pull request May 19, 2017

Closed

[Epic] Auth 2.0.0 #513

1 of 6 tasks complete
@ekryski

This comment has been minimized.

Copy link
Member Author

ekryski commented Jun 1, 2017

@marshallswain Ah shit sorry. I didn't even see your comment. That's a good idea.

@marshallswain marshallswain changed the title Fix 497 Fix default authentication config keys Jun 8, 2017

@marshallswain marshallswain merged commit 79c5be1 into master Jun 8, 2017

4 checks passed

codeclimate no new or fixed issues
Details
codeclimate/coverage 84.62%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ekryski

This comment has been minimized.

Copy link
Member Author

ekryski commented Jun 8, 2017

:shipit:

@marshallswain marshallswain deleted the fix-497 branch Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.