Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made each option, optional #515

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
2 participants
@cranesandcaff
Copy link

cranesandcaff commented May 22, 2017

Summary

This just makes the properties in the auth options as optional. I ran into a compile error with typescript because my type didn't have the required properties and I didn't want to overwrite the defaults.

(If you have not already please refer to the contributing guideline as described
here
)

  • Tell us about the problem your pull request is solving.
  • Are there any open issues that are related to this?
  • Is this PR dependent on PRs in other repos?

If so, please mention them to keep the conversations linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.

If your changes involve documentation updates please mention that and link the appropriate PR in feathers-docs.

Thanks for contributing to Feathers! ❤️

@eddyystop

This comment has been minimized.

Copy link
Member

eddyystop commented May 23, 2017

Thanks! We appreciate TS contributions from the community.

@eddyystop eddyystop merged commit baa9ac4 into feathersjs:master May 23, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.