Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes several issues with update-entity w/ test cases #531

Merged
merged 1 commit into from Jun 21, 2017

Conversation

Projects
None yet
3 participants
@jerfowler
Copy link
Contributor

jerfowler commented Jun 21, 2017

Fixes #529

√ gracefully handles unauthenticated connections
√ updates the passed-in entity when the idField is an ObjectID
√ socket entity should "deep equal" passed-in entity

@jerfowler jerfowler referenced this pull request Jun 21, 2017

Merged

Update socket entity #521

@@ -89,13 +89,14 @@
"jshint": "^2.9.3",
"localstorage-memory": "^1.0.2",
"mocha": "^3.0.2",
"mongodb": "^2.2.29",

This comment has been minimized.

@marshallswain

marshallswain Jun 21, 2017

Member

Is this necessary?

This comment has been minimized.

@jerfowler

jerfowler Jun 21, 2017

Author Contributor

Used to generate an ObjectID from a string value. I probably could stub-out similar functionality, though.

This comment has been minimized.

@marshallswain

marshallswain Jun 21, 2017

Member

Nah. I'm happy with this. Thanks!

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Jun 21, 2017

Oh thank you! I was going to work on this today, but you just saved my schedule. One comment about the MongoDB version number and I'll merge this.

@marshallswain marshallswain merged commit 0d8bbfa into feathersjs:master Jun 21, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jerfowler jerfowler deleted the jerfowler:update-socket-entity-fixes branch Jun 21, 2017

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Jun 21, 2017

Yeah nice fixes. Thanks @jerfowler!

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Jun 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.