Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/typescript fix #585

Merged
merged 3 commits into from Oct 23, 2017

Conversation

Projects
None yet
2 participants
@TimMensch
Copy link
Contributor

TimMensch commented Oct 13, 2017

Summary

TypeScript 2.5.2 in strict mode throws many errors on the built-in index.d.ts declarations. It doesn't seem possible to prevent TypeScript from throwing these errors (the exclude option doesn't work). I feel it's bad form to "ignore" errors, so I'd rather seem them patched in the upstream source.

This is the second of three patches that fixes these errors. I will be submitting a pull request for feathers-hooks shortly.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Oct 23, 2017

Thanks!

@ekryski ekryski merged commit c330e7d into feathersjs:master Oct 23, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.