Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new plugin infrastructure #591

Merged
merged 2 commits into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@daffl
Copy link
Member

daffl commented Oct 24, 2017

statements: [50, 80]

This comment has been minimized.

@ekryski

ekryski Oct 24, 2017

Member

Don't want to bump these watermarks up? I think we should aim for > 90% or >95% coverage on core modules.

This comment has been minimized.

@daffl

daffl Oct 24, 2017

Author Member

We can do that in bulk for all repos once they are done.

@@ -1,12 +1,10 @@
.editorconfig
.jshintrc

This comment has been minimized.

@ekryski

ekryski Oct 24, 2017

Member

probably need .eslintrc.yml in there instead of .jshintrc

@@ -1,107 +0,0 @@
// TODO: don't have the defs from the hooks PR yet, fix later

This comment has been minimized.

@ekryski

This comment has been minimized.

@daffl

daffl Oct 24, 2017

Author Member

Yeah, will be. I don't want to mess with our repos because TypeScript definitions are broken all the time. They'll be published separately and then pulled in.

"lint": "semistandard --fix",
"mocha": "mocha --opts mocha.opts",
"test": "npm run compile && npm run lint && npm run coverage && nsp check",
"test": "npm run lint && npm run coverage",

This comment has been minimized.

@ekryski

ekryski Oct 24, 2017

Member

Are we dropping the nsp check? Does Greenkeeper cover us there?

This comment has been minimized.

@daffl

daffl Oct 24, 2017

Author Member

Nah, good call, added it back.

@ekryski
Copy link
Member

ekryski left a comment

A couple comments. Other than that, looks good.

@daffl daffl merged commit 2fcd91b into master Oct 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the plugin-infrastructure branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.