Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to allowUnauthenticated #599

Merged
merged 13 commits into from Jun 1, 2018

Conversation

Projects
None yet
2 participants
@MichaelErmer
Copy link
Contributor

MichaelErmer commented Nov 2, 2017

Reopening of #449, without the transpiled version.

We really need this feature in the current version as we can not rewrite the entire project again.

To sum up the use case again:
Allow REST endpoints to be accessed without any call to authentication and with authentication present (Show different results and or allow/disallow writes to said endpoints based on hook.params.authenticated)

This is a requirement if you want to provide easy to use public service endpoints, it makes no sense to tell people to call empty authenticate before using it, its just to complicated.

MichaelErmer added some commits Mar 20, 2017

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Jan 19, 2018

Shoot, sorry this has been sitting so long. Would you mind resolving the conflict and I can get it out with the next version?

@MichaelErmer

This comment has been minimized.

Copy link
Contributor Author

MichaelErmer commented May 31, 2018

@daffl yeah lets do this, longest PR ever.

@daffl daffl merged commit 0b11d00 into feathersjs:master Jun 1, 2018

2 checks passed

codeclimate Approved by David Luecke.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.