Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set the JWT UUID if it is not already set #600

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
3 participants
@daffl
Copy link
Member

daffl commented Nov 3, 2017

This is a regression of #539. Basically if you were creating a new token using an existing JWT you always got an error since the jti property is already set in the original payload.

Closes feathersjs/authentication-jwt#43

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Nov 3, 2017

Ah so it is what I thought. Some people were recycling token payloads.

:shipit: Looks good. Thanks for fixing that @daffl!

@daffl daffl merged commit ac0d600 into auk Nov 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the jwtid branch Nov 3, 2017

@xixilive

This comment has been minimized.

Copy link

xixilive commented Jan 12, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.