Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options merged #611

Merged
merged 2 commits into from Jan 19, 2018

Conversation

Projects
None yet
3 participants
@rolandvar
Copy link
Contributor

rolandvar commented Nov 24, 2017

When trying to authenticate through sockets, options are not merged (socket/handler.js#L82), such as hooks hooks/authenticate.js#L55

This can cause the following error if you try to define and use custom strategy:

TypeError: Cannot read property 'entity' of undefined at service.create.then.tokens (@feathersjs\authentication\lib\socket\handler.js:95:31)

rolandvar added some commits Nov 24, 2017

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Jan 19, 2018

This makes sense, thank you and sorry for the delay! Will go out with the next version.

@daffl daffl merged commit ec64bea into feathersjs:master Jan 19, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jamesholcomb

This comment has been minimized.

Copy link

jamesholcomb commented Feb 14, 2018

I am curious if this fix would also address the intermittent "No auth token" NotAuthenticated errors I get over socket.io. I use a custom passport strategy as well.

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Feb 14, 2018

I realized I forgot to make the release. Just published version 2.1.2 so you can give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.