Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ws to the latest version 馃殌 #625

merged 1 commit into from Jan 5, 2018


None yet
1 participant
Copy link

greenkeeper bot commented Jan 5, 2018

Version 4.0.0 of ws was just published.

Dependency ws
Current Version 3.3.3
Type devDependency

The version 4.0.0 is not covered by your current version range.

If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of ws.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don鈥檛 have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.

Release Notes 4.0.0

Breaking changes

  • The close status code is now set to 1005 if the received close frame contains
    no status code (a31b1f6).
  • Error messages and types have been updated (695c5ea).
  • The onerror event handler now receives an ErrorEvent instead of JavaScript
    error (63e275e).
  • The third argument of and
    WebSocket.prototype.pong() is no longer a boolean but an optional callback
  • The non-standard protocolVersion and bytesReceived attributes have been
    removed (7f8ebc6...ee9b5f3).
  • The extensions attribute is no longer an object but a string representing
    the extensions selected by the server (fdec524).
  • The 'headers' event on the client has been renamed to 'upgrade'. Listeners
    of this event now receive only the response argument (1c783c2).
  • The WebSocket.prototype.pause() and WebSocket.prototype.resume() methods
    have been removed to prevent the user from interfering with the state of the
    underlying net.Socket stream (a206e98).

The new version differs by 19 commits.

  • a04d985 [dist] 4.0.0
  • d03ada2 [minor] Rename some variables for clarity
  • a206e98 [major] Remove WebSocket#pause() and WebSocket#resume()
  • 1c783c2 [major] Rename the 'headers' event to 'upgrade'
  • 9bbc978 [test] Reorganize tests
  • fdec524 [fix] Fix extentions property type
  • 46461a9 [minor] Refactor server client initialization
  • ee9b5f3 [major] Remove non-standard bytesReceived attribute
  • 7f8ebc6 [major] Remove non-standard protocolVersion attribute
  • 30c9f71 [major] Make WebSocket#p{i,o}ng() accept an optional callback
  • 63e275e [fix] Pass an ErrorEvent to the onerror event handler
  • 3936f3a [major] Rename modules files
  • 63ce954 [major] Remove ErrorCodes module
  • 695c5ea [major] Improve error messages and use specific error types
  • a31b1f6 [fix] Use 1005 status code if close frame payload length is 0

There are 19 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper bot 馃尨

@greenkeeper greenkeeper bot added the greenkeeper label Jan 5, 2018

@daffl daffl merged commit a2ca592 into master Jan 5, 2018

6 checks passed

codeclimate All good!
codeclimate/diff-coverage 100% (50% threshold)
codeclimate/total-coverage 96% (0.0% change)
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
greenkeeper/verify Greenkeeper verified pull request

@daffl daffl deleted the greenkeeper/ws-4.0.0 branch Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.