Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing client query #65

Merged
merged 3 commits into from Feb 15, 2016

Conversation

Projects
None yet
3 participants
@fastlorenzo
Copy link
Contributor

fastlorenzo commented Feb 15, 2016

Fixing issue #64

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Feb 15, 2016

It looks good. I've got some changes coming in a PR that does the same thing plus some others on the back end side that you are probably unaware of and also adds some tests. Just give me another 15 minutes or so.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Feb 15, 2016

Thanks so much for your help @fastlorenzo! I'm going to close this in favour of #67 because there is actually a bit more that needed to happen to clean up dead code and I thought it would be faster if I just do it rather than explaining everything that needed to be removed and why.

@ekryski ekryski closed this Feb 15, 2016

@ekryski ekryski reopened this Feb 15, 2016

ekryski added a commit that referenced this pull request Feb 15, 2016

@ekryski ekryski merged commit 8a4df0b into feathersjs:master Feb 15, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Feb 15, 2016

Fuck it. I'll merge it to give credit where it is due. Thanks @fastlorenzo!

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Feb 15, 2016

Atta boy! :)

ekryski added a commit that referenced this pull request Feb 15, 2016

Merge pull request #67 from feathersjs/issue-64
Removing assigning token to params.query for sockets. Closes #65.
@fastlorenzo

This comment has been minimized.

Copy link
Contributor Author

fastlorenzo commented Feb 16, 2016

Haha thanks @ekryski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.