Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing assigning token to params.query for sockets. #67

Merged
merged 5 commits into from Feb 15, 2016

Conversation

Projects
None yet
1 participant
@ekryski
Copy link
Member

ekryski commented Feb 15, 2016

Much thanks to @fastlorenzo for pointing this issue out and providing a PR (#65).

There is actually a bit more code to clean up than was done in his PR so I've continued his work with this one. I also wanted to add a few more automated tests to make sure things are still working.

This was referenced Feb 15, 2016

@ekryski ekryski force-pushed the issue-64 branch from ea25079 to 592dfb2 Feb 15, 2016

ekryski added a commit that referenced this pull request Feb 15, 2016

Merge pull request #67 from feathersjs/issue-64
Removing assigning token to params.query for sockets. Closes #65.

@ekryski ekryski merged commit 48ebe0f into master Feb 15, 2016

1 check was pending

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ekryski

This comment has been minimized.

Copy link
Member Author

ekryski commented Feb 15, 2016

Closes #65.

@ekryski ekryski deleted the issue-64 branch Feb 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.