Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subject from the JWT verification options #686

Merged
merged 1 commit into from Jun 29, 2018

Conversation

Projects
None yet
2 participants
@rasendubi
Copy link
Contributor

rasendubi commented Jun 28, 2018

As discussed in #684, the current default for subject causes token
verification to fail if sub is overriden.

Removing subject from default options might be a breaking change as
people might rely on it.

Remove subject from verification options, so it's not checked. This is
a safer way.

Remove subject from the JWT verification options
As discussed in #684, the current default for subject causes token
verification to fail if sub is overriden.

Removing subject from default options might be a breaking change as
people might rely on it.

Remove subject from verification options, so it's not checked. This is
a safer way.

@daffl daffl merged commit 2590cd2 into feathersjs:master Jun 29, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@daffl

This comment has been minimized.

Copy link
Member

daffl commented Jun 29, 2018

Great, thank you! Released as v2.1.7

@rasendubi

This comment has been minimized.

Copy link
Contributor Author

rasendubi commented Jun 29, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.