Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toLowerCase hook #75

Merged
merged 3 commits into from Feb 23, 2016

Conversation

Projects
None yet
4 participants
@enten
Copy link
Contributor

enten commented Feb 23, 2016

PR to fix #74 issue

@marshallswain

This comment has been minimized.

@enten

This comment has been minimized.

Copy link
Contributor Author

enten commented Feb 23, 2016

done!

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Feb 23, 2016

Cool. One more thing I missed, can you revert the version number bump? Our npm release scripts will take care of that.

@enten

This comment has been minimized.

Copy link
Contributor Author

enten commented Feb 23, 2016

done too!

but 0.3.1 it's still into README changelog. have you a script to bump changelog?

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Feb 23, 2016

Updating the changelog is fine.

@marshallswain It looks like there are no tests for this hook correct?

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Feb 23, 2016

Correct. I just checked. That one is untested.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Feb 23, 2016

Ya I'll add some tests today but that is a good fix. Thanks @enten! It's been on my list in auth repo but I haven't had time to get around to it. Honestly, wasn't sure if anyone would use that hook.

ekryski added a commit that referenced this pull request Feb 23, 2016

Merge pull request #75 from enten/master
Fix toLowerCase hook

@ekryski ekryski merged commit fafeb88 into feathersjs:master Feb 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@enten

This comment has been minimized.

Copy link
Contributor Author

enten commented Feb 23, 2016

Thanks!

I thinks that is it a great helper for fields with an unicity constraint (like username or email).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.