Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for storage service #76

Merged
merged 9 commits into from Feb 27, 2016

Conversation

Projects
None yet
2 participants
@ekryski
Copy link
Member

ekryski commented Feb 24, 2016

Initial refactoring and tests for client side authentication that works with a storage service. In order to support caching of tokens and the current user on React Native, NodeJS and the browser we needed an abstraction over top of localStorage, AsyncStorage. So it made sense to create a service adapter that abstracts the underlying storage mechanism. We've done this with https://github.com/feathersjs/feathers-localstorage.

This will be able to be merged once feathersjs-ecosystem/feathers-localstorage#1 lands and then we will be able to use feathers-authentication in React Native and Node. 馃槃

@ekryski

This comment has been minimized.

Copy link
Member Author

ekryski commented Feb 24, 2016

Still a WIP. Opened for visibility. Do not merge yet.

@ekryski

This comment has been minimized.

Copy link
Member Author

ekryski commented Feb 27, 2016

Pending tests passing this should be good to merge. Has been manually tested with React Native and the browser.

@ekryski ekryski force-pushed the client-auth branch from 53b0032 to c674937 Feb 27, 2016

ekryski added a commit that referenced this pull request Feb 27, 2016

Merge pull request #76 from feathersjs/client-auth
Refactoring for storage service

@ekryski ekryski merged commit fc7f4e9 into master Feb 27, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@ekryski ekryski deleted the client-auth branch Feb 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.