Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for OAuth2 token based auth strategies. Closes #46. #77

Merged
merged 3 commits into from Feb 25, 2016

Conversation

Projects
None yet
2 participants
@ekryski
Copy link
Member

ekryski commented Feb 24, 2016

This adds support for authenticating via OAuth tokens if a tokenService is configured by POSTing an auth_token to a Feathers OAuth service. For example:

POST /auth/facebook { "auth_token": "your token" }

This allows a mobile (or some other device) to not have to embed the clientID and clientSecret and just let the server manage that. Most of the time this is when a mobile client does authentication between apps.

An example of a token strategy would be: https://github.com/drudge/passport-facebook-token.

.catch(reject);
});

middleware(params.req, params.res, function() {

This comment has been minimized.

@daffl

daffl Feb 24, 2016

Member

This was probably just for debug right?

This comment has been minimized.

@ekryski

ekryski Feb 24, 2016

Author Member

lol yup. I was just opening PRs last night for visibility. I still have some work to do in this branch depending on how we want to support OAuth redirects back for mobile.

@ekryski

This comment has been minimized.

Copy link
Member Author

ekryski commented Feb 24, 2016

Going to roll this in as a minor release because the generator, generates code that needs this in order to work. If there is any client side specific stuff that needs to happen for React Native we can deal with that in another PR.

ekryski added a commit that referenced this pull request Feb 25, 2016

Merge pull request #77 from feathersjs/mobile-auth
Adding support for OAuth2 token based auth strategies. Closes #46.

@ekryski ekryski merged commit 013badf into master Feb 25, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ekryski ekryski deleted the mobile-auth branch Feb 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.