Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update populateUser() hook #87

Merged
merged 1 commit into from Feb 29, 2016

Conversation

Projects
None yet
2 participants
@kulakowka
Copy link
Contributor

kulakowka commented Feb 29, 2016

  • get auth options from app config;
  • use idField from auth options for get user by id

I'm not sure that everything is done correctly. It would be great if the author of the hook will make review for this PR.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Feb 29, 2016

@kulakowka nice! This was on my list of todos, so thanks! Looks good.

I'm finally sitting down to write test for this stuff so I'll merge it in and fix anything if it's not working as expected.

ekryski added a commit that referenced this pull request Feb 29, 2016

@ekryski ekryski merged commit 66604ab into feathersjs:master Feb 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.