Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added generators for feathers-objection & feathers-cassandra #1010

Merged
merged 8 commits into from Sep 24, 2018
Merged

Added generators for feathers-objection & feathers-cassandra #1010

merged 8 commits into from Sep 24, 2018

Conversation

dekelev
Copy link
Contributor

@dekelev dekelev commented Sep 19, 2018

No description provided.

@daffl
Copy link
Member

daffl commented Sep 20, 2018

This is great, thank you! I'll have a look at it on the weekend.

In order to keep them as official adapters in the future, do you plan on including the changes coming in #925?

@dekelev
Copy link
Contributor Author

dekelev commented Sep 21, 2018

Sure, these changes makes a lot of sense.

feathers-objection allows eager queries, like mongoose's $populate, but for example, allowedEager: 'todos' in the users service options acts as the whitelist and will only allow getting user.todos, using query.$eager = 'todos'.
allowedEager: '[todos, account]' will also allow getting the account relation.

feathers-objection also has Upsert/Insert feature, which will update relations too. this requires the allowedUpsert, allowedInsert and createUseUpsertGraph service options.

feathers-cassandra doesn't support relations, so I can't think of anything there that needs whitelisting.

Both packages should already respect the query object in get, remove, update and patch, but I'll test this to verify.

I'll add support & docs for the multi service option in both projects.

BTW, I've recently added the keepInArray common hook to control which relation's properties are returned to the client.

Let me know if you can think of anything else. enjoy your weekend!

@daffl
Copy link
Member

daffl commented Sep 21, 2018

I'll keep you in the loop what the plan is with those updates and will try to get your PR in soon.

@daffl daffl merged commit c8b27d0 into feathersjs:master Sep 24, 2018
@daffl
Copy link
Member

daffl commented Sep 24, 2018

Released in @feathersjs/cli@3.8.5, thank you again for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants