From 98bb1f8f8d0f5cb8251ef065f97f10a5d566044f Mon Sep 17 00:00:00 2001 From: Ashot Nazaryan Date: Wed, 10 Apr 2024 01:33:46 -0700 Subject: [PATCH 1/2] Commited is boolean type The docs https://feathersjs.com/api/databases/knex#transactions say that committed is either true or false --- packages/knex/src/declarations.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/knex/src/declarations.ts b/packages/knex/src/declarations.ts index 4e30ba6a0a..8a10015a2a 100644 --- a/packages/knex/src/declarations.ts +++ b/packages/knex/src/declarations.ts @@ -10,7 +10,7 @@ export interface KnexAdapterOptions extends AdapterServiceOptions { export interface KnexAdapterTransaction { starting: boolean parent?: KnexAdapterTransaction - committed?: any + committed?: boolean resolve?: any trx?: Knex.Transaction id?: number From 11ddb35dd6285dcb86d38070ac3ae63d6a344d5d Mon Sep 17 00:00:00 2001 From: Ashot Nazaryan Date: Wed, 10 Apr 2024 11:55:22 -0700 Subject: [PATCH 2/2] commited is a promise --- packages/knex/src/declarations.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/knex/src/declarations.ts b/packages/knex/src/declarations.ts index 8a10015a2a..70ad267dca 100644 --- a/packages/knex/src/declarations.ts +++ b/packages/knex/src/declarations.ts @@ -10,7 +10,7 @@ export interface KnexAdapterOptions extends AdapterServiceOptions { export interface KnexAdapterTransaction { starting: boolean parent?: KnexAdapterTransaction - committed?: boolean + committed?: Promise resolve?: any trx?: Knex.Transaction id?: number