From c03b54e6bf20116fe50be3208da7b16840917895 Mon Sep 17 00:00:00 2001 From: Soledad Galli Date: Sat, 28 Jan 2023 21:44:06 -0300 Subject: [PATCH 1/3] take docstrings outside imputer base class --- feature_engine/_docstrings/fit_attributes.py | 4 +++ feature_engine/_docstrings/methods.py | 5 +++ feature_engine/imputation/arbitrary_number.py | 32 ++++++++----------- feature_engine/imputation/base_imputer.py | 16 ++-------- feature_engine/imputation/categorical.py | 22 ++++++------- .../imputation/drop_missing_data.py | 14 +++----- feature_engine/imputation/end_tail.py | 27 ++++++++-------- feature_engine/imputation/mean_median.py | 27 ++++++++-------- .../imputation/missing_indicator.py | 14 +++----- feature_engine/imputation/random_sample.py | 21 ++++++------ 10 files changed, 78 insertions(+), 104 deletions(-) diff --git a/feature_engine/_docstrings/fit_attributes.py b/feature_engine/_docstrings/fit_attributes.py index a1edaa495..789b690dc 100644 --- a/feature_engine/_docstrings/fit_attributes.py +++ b/feature_engine/_docstrings/fit_attributes.py @@ -15,3 +15,7 @@ _binner_dict_docstring = """binner_dict_: Dictionary with the interval limits per variable. """.rstrip() + +_imputer_dict_docstring = """imputer_dict_: + Dictionary with the values to replace missing data in each variable. + """.rstrip() diff --git a/feature_engine/_docstrings/methods.py b/feature_engine/_docstrings/methods.py index b734d5613..9112526c1 100644 --- a/feature_engine/_docstrings/methods.py +++ b/feature_engine/_docstrings/methods.py @@ -40,3 +40,8 @@ _transform_discretiser_docstring = """transform: Sort continuous variable values into the intervals. """.rstrip() + +# used in imputation module +_transform_imputers_docstring = """transform: + Impute missing data. + """.rstrip() diff --git a/feature_engine/imputation/arbitrary_number.py b/feature_engine/imputation/arbitrary_number.py index fc920e2de..96c018be8 100644 --- a/feature_engine/imputation/arbitrary_number.py +++ b/feature_engine/imputation/arbitrary_number.py @@ -5,36 +5,30 @@ import pandas as pd -from feature_engine._check_input_parameters.check_input_dictionary import ( - _check_numerical_dict, -) +from feature_engine._check_input_parameters.check_input_dictionary import \ + _check_numerical_dict from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, - _n_features_in_docstring, - _variables_attribute_docstring, -) -from feature_engine._docstrings.methods import ( - _fit_not_learn_docstring, - _fit_transform_docstring, -) + _feature_names_in_docstring, _imputer_dict_docstring, + _n_features_in_docstring, _variables_attribute_docstring) +from feature_engine._docstrings.methods import (_fit_not_learn_docstring, + _fit_transform_docstring, + _transform_imputers_docstring) from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import ( - _check_init_parameter_variables, -) -from feature_engine._variable_handling.variable_type_selection import ( - _find_or_check_numerical_variables, -) +from feature_engine._variable_handling.init_parameter_checks import \ + _check_init_parameter_variables +from feature_engine._variable_handling.variable_type_selection import \ + _find_or_check_numerical_variables from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer @Substitution( - imputer_dict_=BaseImputer._imputer_dict_docstring, + imputer_dict_=_imputer_dict_docstring, variables_=_variables_attribute_docstring, feature_names_in_=_feature_names_in_docstring, n_features_in_=_n_features_in_docstring, fit=_fit_not_learn_docstring, - transform=BaseImputer._transform_docstring, + transform=_transform_imputers_docstring, fit_transform=_fit_transform_docstring, ) class ArbitraryNumberImputer(BaseImputer): diff --git a/feature_engine/imputation/base_imputer.py b/feature_engine/imputation/base_imputer.py index d1bb58b19..7b3fe5a45 100644 --- a/feature_engine/imputation/base_imputer.py +++ b/feature_engine/imputation/base_imputer.py @@ -2,27 +2,15 @@ from sklearn.base import BaseEstimator, TransformerMixin from sklearn.utils.validation import check_is_fitted -from feature_engine.dataframe_checks import _check_X_matches_training_df, check_X from feature_engine._base_transformers.mixins import GetFeatureNamesOutMixin +from feature_engine.dataframe_checks import (_check_X_matches_training_df, + check_X) from feature_engine.tags import _return_tags class BaseImputer(BaseEstimator, TransformerMixin, GetFeatureNamesOutMixin): """shared set-up checks and methods across imputers""" - _variables_numerical_docstring = """variables: list, default=None - The list of variables to impute. If None, the imputer will select - all numerical variables. - """.rstrip() - - _imputer_dict_docstring = """imputer_dict_: - Dictionary with the values to replace missing data in each variable. - """.rstrip() - - _transform_docstring = """transform: - Impute missing data. - """.rstrip() - def _transform(self, X: pd.DataFrame) -> pd.DataFrame: """ Common checks before transforming data: diff --git a/feature_engine/imputation/categorical.py b/feature_engine/imputation/categorical.py index bbda7c098..9f9a1e39c 100644 --- a/feature_engine/imputation/categorical.py +++ b/feature_engine/imputation/categorical.py @@ -6,30 +6,26 @@ import pandas as pd from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, - _n_features_in_docstring, - _variables_attribute_docstring, -) -from feature_engine._docstrings.methods import _fit_transform_docstring + _feature_names_in_docstring, _imputer_dict_docstring, + _n_features_in_docstring, _variables_attribute_docstring) +from feature_engine._docstrings.methods import (_fit_transform_docstring, + _transform_imputers_docstring) from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import ( - _check_init_parameter_variables, -) +from feature_engine._variable_handling.init_parameter_checks import \ + _check_init_parameter_variables from feature_engine._variable_handling.variable_type_selection import ( - _find_all_variables, - _find_or_check_categorical_variables, -) + _find_all_variables, _find_or_check_categorical_variables) from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer from feature_engine.tags import _return_tags @Substitution( - imputer_dict_=BaseImputer._imputer_dict_docstring, + imputer_dict_=_imputer_dict_docstring, variables_=_variables_attribute_docstring, feature_names_in_=_feature_names_in_docstring, n_features_in_=_n_features_in_docstring, - transform=BaseImputer._transform_docstring, + transform=_transform_imputers_docstring, fit_transform=_fit_transform_docstring, ) class CategoricalImputer(BaseImputer): diff --git a/feature_engine/imputation/drop_missing_data.py b/feature_engine/imputation/drop_missing_data.py index b13f2a849..581307246 100644 --- a/feature_engine/imputation/drop_missing_data.py +++ b/feature_engine/imputation/drop_missing_data.py @@ -6,17 +6,13 @@ import pandas as pd from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, - _n_features_in_docstring, -) + _feature_names_in_docstring, _n_features_in_docstring) from feature_engine._docstrings.methods import _fit_transform_docstring from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import ( - _check_init_parameter_variables, -) -from feature_engine._variable_handling.variable_type_selection import ( - _find_all_variables, -) +from feature_engine._variable_handling.init_parameter_checks import \ + _check_init_parameter_variables +from feature_engine._variable_handling.variable_type_selection import \ + _find_all_variables from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer from feature_engine.tags import _return_tags diff --git a/feature_engine/imputation/end_tail.py b/feature_engine/imputation/end_tail.py index 907339e2e..54d165e14 100644 --- a/feature_engine/imputation/end_tail.py +++ b/feature_engine/imputation/end_tail.py @@ -6,29 +6,28 @@ import pandas as pd from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, - _n_features_in_docstring, - _variables_attribute_docstring, -) -from feature_engine._docstrings.methods import _fit_transform_docstring + _feature_names_in_docstring, _imputer_dict_docstring, + _n_features_in_docstring, _variables_attribute_docstring) +from feature_engine._docstrings.init_parameters.all_trasnformers import \ + _variables_numerical_docstring +from feature_engine._docstrings.methods import (_fit_transform_docstring, + _transform_imputers_docstring) from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import ( - _check_init_parameter_variables, -) -from feature_engine._variable_handling.variable_type_selection import ( - _find_or_check_numerical_variables, -) +from feature_engine._variable_handling.init_parameter_checks import \ + _check_init_parameter_variables +from feature_engine._variable_handling.variable_type_selection import \ + _find_or_check_numerical_variables from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer @Substitution( - variables=BaseImputer._variables_numerical_docstring, - imputer_dict_=BaseImputer._imputer_dict_docstring, + variables=_variables_numerical_docstring, + imputer_dict_=_imputer_dict_docstring, variables_=_variables_attribute_docstring, feature_names_in_=_feature_names_in_docstring, n_features_in_=_n_features_in_docstring, - transform=BaseImputer._transform_docstring, + transform=_transform_imputers_docstring, fit_transform=_fit_transform_docstring, ) class EndTailImputer(BaseImputer): diff --git a/feature_engine/imputation/mean_median.py b/feature_engine/imputation/mean_median.py index 824c4dfcc..ed1cbfbb0 100644 --- a/feature_engine/imputation/mean_median.py +++ b/feature_engine/imputation/mean_median.py @@ -6,29 +6,28 @@ import pandas as pd from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, - _n_features_in_docstring, - _variables_attribute_docstring, -) -from feature_engine._docstrings.methods import _fit_transform_docstring + _feature_names_in_docstring, _imputer_dict_docstring, + _n_features_in_docstring, _variables_attribute_docstring) +from feature_engine._docstrings.init_parameters.all_trasnformers import \ + _variables_numerical_docstring +from feature_engine._docstrings.methods import (_fit_transform_docstring, + _transform_imputers_docstring) from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import ( - _check_init_parameter_variables, -) -from feature_engine._variable_handling.variable_type_selection import ( - _find_or_check_numerical_variables, -) +from feature_engine._variable_handling.init_parameter_checks import \ + _check_init_parameter_variables +from feature_engine._variable_handling.variable_type_selection import \ + _find_or_check_numerical_variables from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer @Substitution( - variables=BaseImputer._variables_numerical_docstring, - imputer_dict_=BaseImputer._imputer_dict_docstring, + variables=_variables_numerical_docstring, + imputer_dict_=_imputer_dict_docstring, variables_=_variables_attribute_docstring, feature_names_in_=_feature_names_in_docstring, n_features_in_=_n_features_in_docstring, - transform=BaseImputer._transform_docstring, + transform=_transform_imputers_docstring, fit_transform=_fit_transform_docstring, ) class MeanMedianImputer(BaseImputer): diff --git a/feature_engine/imputation/missing_indicator.py b/feature_engine/imputation/missing_indicator.py index ee09dd598..78911fa97 100644 --- a/feature_engine/imputation/missing_indicator.py +++ b/feature_engine/imputation/missing_indicator.py @@ -6,17 +6,13 @@ import pandas as pd from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, - _n_features_in_docstring, -) + _feature_names_in_docstring, _n_features_in_docstring) from feature_engine._docstrings.methods import _fit_transform_docstring from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import ( - _check_init_parameter_variables, -) -from feature_engine._variable_handling.variable_type_selection import ( - _find_all_variables, -) +from feature_engine._variable_handling.init_parameter_checks import \ + _check_init_parameter_variables +from feature_engine._variable_handling.variable_type_selection import \ + _find_all_variables from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer from feature_engine.tags import _return_tags diff --git a/feature_engine/imputation/random_sample.py b/feature_engine/imputation/random_sample.py index 71837a86f..1e60a58a5 100644 --- a/feature_engine/imputation/random_sample.py +++ b/feature_engine/imputation/random_sample.py @@ -7,18 +7,15 @@ import pandas as pd from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, - _n_features_in_docstring, - _variables_attribute_docstring, -) -from feature_engine._docstrings.methods import _fit_transform_docstring + _feature_names_in_docstring, _n_features_in_docstring, + _variables_attribute_docstring) +from feature_engine._docstrings.methods import (_fit_transform_docstring, + _transform_imputers_docstring) from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import ( - _check_init_parameter_variables, -) -from feature_engine._variable_handling.variable_type_selection import ( - _find_all_variables, -) +from feature_engine._variable_handling.init_parameter_checks import \ + _check_init_parameter_variables +from feature_engine._variable_handling.variable_type_selection import \ + _find_all_variables from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer from feature_engine.tags import _return_tags @@ -44,7 +41,7 @@ def _define_seed( variables_=_variables_attribute_docstring, feature_names_in_=_feature_names_in_docstring, n_features_in_=_n_features_in_docstring, - transform=BaseImputer._transform_docstring, + transform=_transform_imputers_docstring, fit_transform=_fit_transform_docstring, ) class RandomSampleImputer(BaseImputer): From 26ecfb3a23773655c7e10e0ebe070fc4ff541097 Mon Sep 17 00:00:00 2001 From: Soledad Galli Date: Sat, 28 Jan 2023 21:46:23 -0300 Subject: [PATCH 2/3] black imputation module --- feature_engine/imputation/arbitrary_number.py | 30 ++++++++++++------- feature_engine/imputation/base_imputer.py | 3 +- feature_engine/imputation/categorical.py | 22 +++++++++----- .../imputation/drop_missing_data.py | 14 +++++---- feature_engine/imputation/end_tail.py | 28 ++++++++++------- feature_engine/imputation/mean_median.py | 28 ++++++++++------- .../imputation/missing_indicator.py | 14 +++++---- feature_engine/imputation/random_sample.py | 22 +++++++++----- 8 files changed, 103 insertions(+), 58 deletions(-) diff --git a/feature_engine/imputation/arbitrary_number.py b/feature_engine/imputation/arbitrary_number.py index 96c018be8..8e1767c31 100644 --- a/feature_engine/imputation/arbitrary_number.py +++ b/feature_engine/imputation/arbitrary_number.py @@ -5,19 +5,27 @@ import pandas as pd -from feature_engine._check_input_parameters.check_input_dictionary import \ - _check_numerical_dict +from feature_engine._check_input_parameters.check_input_dictionary import ( + _check_numerical_dict, +) from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, _imputer_dict_docstring, - _n_features_in_docstring, _variables_attribute_docstring) -from feature_engine._docstrings.methods import (_fit_not_learn_docstring, - _fit_transform_docstring, - _transform_imputers_docstring) + _feature_names_in_docstring, + _imputer_dict_docstring, + _n_features_in_docstring, + _variables_attribute_docstring, +) +from feature_engine._docstrings.methods import ( + _fit_not_learn_docstring, + _fit_transform_docstring, + _transform_imputers_docstring, +) from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import \ - _check_init_parameter_variables -from feature_engine._variable_handling.variable_type_selection import \ - _find_or_check_numerical_variables +from feature_engine._variable_handling.init_parameter_checks import ( + _check_init_parameter_variables, +) +from feature_engine._variable_handling.variable_type_selection import ( + _find_or_check_numerical_variables, +) from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer diff --git a/feature_engine/imputation/base_imputer.py b/feature_engine/imputation/base_imputer.py index 7b3fe5a45..60dee5df9 100644 --- a/feature_engine/imputation/base_imputer.py +++ b/feature_engine/imputation/base_imputer.py @@ -3,8 +3,7 @@ from sklearn.utils.validation import check_is_fitted from feature_engine._base_transformers.mixins import GetFeatureNamesOutMixin -from feature_engine.dataframe_checks import (_check_X_matches_training_df, - check_X) +from feature_engine.dataframe_checks import _check_X_matches_training_df, check_X from feature_engine.tags import _return_tags diff --git a/feature_engine/imputation/categorical.py b/feature_engine/imputation/categorical.py index 9f9a1e39c..8f77e3385 100644 --- a/feature_engine/imputation/categorical.py +++ b/feature_engine/imputation/categorical.py @@ -6,15 +6,23 @@ import pandas as pd from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, _imputer_dict_docstring, - _n_features_in_docstring, _variables_attribute_docstring) -from feature_engine._docstrings.methods import (_fit_transform_docstring, - _transform_imputers_docstring) + _feature_names_in_docstring, + _imputer_dict_docstring, + _n_features_in_docstring, + _variables_attribute_docstring, +) +from feature_engine._docstrings.methods import ( + _fit_transform_docstring, + _transform_imputers_docstring, +) from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import \ - _check_init_parameter_variables +from feature_engine._variable_handling.init_parameter_checks import ( + _check_init_parameter_variables, +) from feature_engine._variable_handling.variable_type_selection import ( - _find_all_variables, _find_or_check_categorical_variables) + _find_all_variables, + _find_or_check_categorical_variables, +) from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer from feature_engine.tags import _return_tags diff --git a/feature_engine/imputation/drop_missing_data.py b/feature_engine/imputation/drop_missing_data.py index 581307246..b13f2a849 100644 --- a/feature_engine/imputation/drop_missing_data.py +++ b/feature_engine/imputation/drop_missing_data.py @@ -6,13 +6,17 @@ import pandas as pd from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, _n_features_in_docstring) + _feature_names_in_docstring, + _n_features_in_docstring, +) from feature_engine._docstrings.methods import _fit_transform_docstring from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import \ - _check_init_parameter_variables -from feature_engine._variable_handling.variable_type_selection import \ - _find_all_variables +from feature_engine._variable_handling.init_parameter_checks import ( + _check_init_parameter_variables, +) +from feature_engine._variable_handling.variable_type_selection import ( + _find_all_variables, +) from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer from feature_engine.tags import _return_tags diff --git a/feature_engine/imputation/end_tail.py b/feature_engine/imputation/end_tail.py index 54d165e14..5b316ad25 100644 --- a/feature_engine/imputation/end_tail.py +++ b/feature_engine/imputation/end_tail.py @@ -6,17 +6,25 @@ import pandas as pd from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, _imputer_dict_docstring, - _n_features_in_docstring, _variables_attribute_docstring) -from feature_engine._docstrings.init_parameters.all_trasnformers import \ - _variables_numerical_docstring -from feature_engine._docstrings.methods import (_fit_transform_docstring, - _transform_imputers_docstring) + _feature_names_in_docstring, + _imputer_dict_docstring, + _n_features_in_docstring, + _variables_attribute_docstring, +) +from feature_engine._docstrings.init_parameters.all_trasnformers import ( + _variables_numerical_docstring, +) +from feature_engine._docstrings.methods import ( + _fit_transform_docstring, + _transform_imputers_docstring, +) from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import \ - _check_init_parameter_variables -from feature_engine._variable_handling.variable_type_selection import \ - _find_or_check_numerical_variables +from feature_engine._variable_handling.init_parameter_checks import ( + _check_init_parameter_variables, +) +from feature_engine._variable_handling.variable_type_selection import ( + _find_or_check_numerical_variables, +) from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer diff --git a/feature_engine/imputation/mean_median.py b/feature_engine/imputation/mean_median.py index ed1cbfbb0..38d7b8cbb 100644 --- a/feature_engine/imputation/mean_median.py +++ b/feature_engine/imputation/mean_median.py @@ -6,17 +6,25 @@ import pandas as pd from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, _imputer_dict_docstring, - _n_features_in_docstring, _variables_attribute_docstring) -from feature_engine._docstrings.init_parameters.all_trasnformers import \ - _variables_numerical_docstring -from feature_engine._docstrings.methods import (_fit_transform_docstring, - _transform_imputers_docstring) + _feature_names_in_docstring, + _imputer_dict_docstring, + _n_features_in_docstring, + _variables_attribute_docstring, +) +from feature_engine._docstrings.init_parameters.all_trasnformers import ( + _variables_numerical_docstring, +) +from feature_engine._docstrings.methods import ( + _fit_transform_docstring, + _transform_imputers_docstring, +) from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import \ - _check_init_parameter_variables -from feature_engine._variable_handling.variable_type_selection import \ - _find_or_check_numerical_variables +from feature_engine._variable_handling.init_parameter_checks import ( + _check_init_parameter_variables, +) +from feature_engine._variable_handling.variable_type_selection import ( + _find_or_check_numerical_variables, +) from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer diff --git a/feature_engine/imputation/missing_indicator.py b/feature_engine/imputation/missing_indicator.py index 78911fa97..ee09dd598 100644 --- a/feature_engine/imputation/missing_indicator.py +++ b/feature_engine/imputation/missing_indicator.py @@ -6,13 +6,17 @@ import pandas as pd from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, _n_features_in_docstring) + _feature_names_in_docstring, + _n_features_in_docstring, +) from feature_engine._docstrings.methods import _fit_transform_docstring from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import \ - _check_init_parameter_variables -from feature_engine._variable_handling.variable_type_selection import \ - _find_all_variables +from feature_engine._variable_handling.init_parameter_checks import ( + _check_init_parameter_variables, +) +from feature_engine._variable_handling.variable_type_selection import ( + _find_all_variables, +) from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer from feature_engine.tags import _return_tags diff --git a/feature_engine/imputation/random_sample.py b/feature_engine/imputation/random_sample.py index 1e60a58a5..d1f7f433c 100644 --- a/feature_engine/imputation/random_sample.py +++ b/feature_engine/imputation/random_sample.py @@ -7,15 +7,21 @@ import pandas as pd from feature_engine._docstrings.fit_attributes import ( - _feature_names_in_docstring, _n_features_in_docstring, - _variables_attribute_docstring) -from feature_engine._docstrings.methods import (_fit_transform_docstring, - _transform_imputers_docstring) + _feature_names_in_docstring, + _n_features_in_docstring, + _variables_attribute_docstring, +) +from feature_engine._docstrings.methods import ( + _fit_transform_docstring, + _transform_imputers_docstring, +) from feature_engine._docstrings.substitute import Substitution -from feature_engine._variable_handling.init_parameter_checks import \ - _check_init_parameter_variables -from feature_engine._variable_handling.variable_type_selection import \ - _find_all_variables +from feature_engine._variable_handling.init_parameter_checks import ( + _check_init_parameter_variables, +) +from feature_engine._variable_handling.variable_type_selection import ( + _find_all_variables, +) from feature_engine.dataframe_checks import check_X from feature_engine.imputation.base_imputer import BaseImputer from feature_engine.tags import _return_tags From 5a2f8cbb91885aeedb542d2bf03f417bfe3d5bea Mon Sep 17 00:00:00 2001 From: Soledad Galli Date: Sat, 28 Jan 2023 21:53:03 -0300 Subject: [PATCH 3/3] fix indentation --- feature_engine/_docstrings/methods.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/feature_engine/_docstrings/methods.py b/feature_engine/_docstrings/methods.py index 9112526c1..a49042db7 100644 --- a/feature_engine/_docstrings/methods.py +++ b/feature_engine/_docstrings/methods.py @@ -43,5 +43,5 @@ # used in imputation module _transform_imputers_docstring = """transform: - Impute missing data. + Impute missing data. """.rstrip()