Fix NuGet pack CI step: build in Release mode and exclude Benchmarks #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes CI failure in NuGet pack step by ensuring Release mode build and excluding the Benchmarks project from packaging.
- Changed pack command to explicitly build in Release configuration instead of skipping build
- Excluded Benchmarks project from NuGet packaging
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/F23.StringSimilarity.Benchmarks/F23.StringSimilarity.Benchmarks.csproj | Added IsPackable property to prevent benchmark project from being packaged |
| .github/workflows/dotnet.yml | Modified pack command to build in Release mode instead of using pre-built artifacts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…project Remove --no-build flag to allow dotnet pack to build in Release mode instead of reusing the Debug build. Add IsPackable=false to Benchmarks project to prevent it from being included in NuGet packs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
paulirwin
force-pushed
the
chore/fix-nuget-pack
branch
from
d9aaadd to
7a37d45
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--no-buildflag from pack command so it builds in Release modeIsPackable=falseFixes the CI failure from the previous NuGet pack PR.
Changes
.github/workflows/dotnet.ymlto usedotnet pack -c Releaseinstead ofdotnet pack --no-build<IsPackable>false</IsPackable>to Benchmarks project fileTest plan
🤖 Generated with Claude Code