New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify ignore_variables docstring #117

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented Mar 23, 2018

The value in the ignore_variable dict takes in a list, not a string. In particular, the loop in DeepFeatureSynthesis

for eid, vars in ignore_variables.items():
    self.ignore_variables[eid] = set(vars)

will take the dictionary ignore_variables = {'hello': 'world'} to self.ignore_variables['hello'] = {'d', 'l', 'o', 'r', 'w'}. This PR updates the docstring to reflect the correct input type.

Seth-Rothschild
@kmax12

This comment has been minimized.

Member

kmax12 commented Mar 23, 2018

Looks great. Merging

@codecov-io

This comment has been minimized.

codecov-io commented Mar 23, 2018

Codecov Report

Merging #117 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   88.27%   88.33%   +0.05%     
==========================================
  Files          73       73              
  Lines        7457     7457              
==========================================
+ Hits         6583     6587       +4     
+ Misses        874      870       -4
Impacted Files Coverage Δ
featuretools/synthesis/dfs.py 100% <ø> (ø) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 93.06% <ø> (ø) ⬆️
featuretools/demo/flight.py 35.48% <0%> (+12.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f8338...b390d5e. Read the comment docs.

@kmax12 kmax12 merged commit 42fa515 into master Mar 23, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Seth-Rothschild Seth-Rothschild deleted the ignore_variable_docstring branch Mar 30, 2018

@rwedge rwedge referenced this pull request Apr 13, 2018

Merged

Release v0.1.20 #131

rwedge added a commit that referenced this pull request Apr 13, 2018

Release v0.1.20 (#131)
**v0.1.20** Apr 13, 2018
* Improved chunking when calculating feature matrices  (#121)
* Primitives as strings in DFS parameters (#129)
* Integer time index bugfixes (#128)
* Add make_temporal_cutoffs utility function (#126)
* Show all entities, switch shape display to row/col (#124)
* fixed num characters nan fix (#118)
* modify ignore_variables docstring (#117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment