New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make_temporal_cutoffs utility function #126

merged 8 commits into from Apr 5, 2018


None yet
3 participants

bschreck commented Mar 30, 2018

Adds 2 new utility functions:

make_temporal_cutoffs() creates multiple evenly spaced cutoff times for each instance prior to the specified input cutoff times
tdfs() is a wrapper around dfs() that calls make_temporal_cutoffs and passes the resulting multiple time windows into dfs(). The result is a flattened feature tensor, with multiple values per instance. This feature tensor can be used for temporal machine learning algorithms, such as Recurrent Neural Networks.

@kmax12 kmax12 changed the title from TDFS to Add make_temporal_cutoffs utility function Apr 2, 2018


This comment has been minimized.

codecov-io commented Apr 3, 2018

Codecov Report

Merging #126 into master will increase coverage by 0.03%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
+ Coverage   88.47%   88.51%   +0.03%     
  Files          73       75       +2     
  Lines        7558     7591      +33     
+ Hits         6687     6719      +32     
- Misses        871      872       +1
Impacted Files Coverage Δ
featuretools/utils/ 100% <100%> (ø) ⬆️
featuretools/utils/ 100% <100%> (ø)
featuretools/tests/utils_tests/ 95.65% <95.65%> (ø)
featuretools/entityset/ 91.11% <0%> (ø) ⬆️
featuretools/entityset/ 76.78% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59fc551...842928e. Read the comment docs.

import pandas as pd
def make_temporal_cutoffs(instance_ids,

This comment has been minimized.


kmax12 Apr 3, 2018


can you add a proper docstring to this function for the api reference?

bschreck added some commits Apr 4, 2018

import featuretools as ft

This comment has been minimized.


kmax12 Apr 5, 2018


i don't think you need this import

@bschreck bschreck merged commit 2027c04 into master Apr 5, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
license/cla Contributor License Agreement is signed.

@bschreck bschreck deleted the tdfs branch Apr 5, 2018

@rwedge rwedge referenced this pull request Apr 13, 2018


Release v0.1.20 #131

rwedge added a commit that referenced this pull request Apr 13, 2018

Release v0.1.20 (#131)
**v0.1.20** Apr 13, 2018
* Improved chunking when calculating feature matrices  (#121)
* Primitives as strings in DFS parameters (#129)
* Integer time index bugfixes (#128)
* Add make_temporal_cutoffs utility function (#126)
* Show all entities, switch shape display to row/col (#124)
* fixed num characters nan fix (#118)
* modify ignore_variables docstring (#117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment