New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntitySet repr to use get_name rather than id #134

Merged
merged 1 commit into from May 2, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented Apr 30, 2018

When showing an entityset name, use the get_name method rather than es.id.

@codecov-io

This comment has been minimized.

codecov-io commented Apr 30, 2018

Codecov Report

Merging #134 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   88.76%   88.77%   +0.01%     
==========================================
  Files          75       75              
  Lines        7803     7803              
==========================================
+ Hits         6926     6927       +1     
+ Misses        877      876       -1
Impacted Files Coverage Δ
featuretools/entityset/base_entityset.py 91.16% <ø> (ø) ⬆️
featuretools/utils/gen_utils.py 66.66% <0%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d36f1...965dbc0. Read the comment docs.

@kmax12 kmax12 merged commit b5d1a56 into master May 2, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Seth-Rothschild Seth-Rothschild deleted the fix_es_repr branch May 2, 2018

@rwedge rwedge referenced this pull request May 30, 2018

Merged

v0.1.21 #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment