New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Entity unit tests #136

Merged
merged 8 commits into from May 7, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented May 1, 2018

Add tests to test_entity

@codecov-io

This comment has been minimized.

codecov-io commented May 1, 2018

Codecov Report

Merging #136 into master will increase coverage by 0.75%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   89.98%   90.73%   +0.75%     
==========================================
  Files          76       76              
  Lines        7827     7824       -3     
==========================================
+ Hits         7043     7099      +56     
+ Misses        784      725      -59
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_entity.py 100% <100%> (ø) ⬆️
...computational_backends/calculate_feature_matrix.py 98.58% <0%> (-0.06%) ⬇️
featuretools/entityset/entityset.py 90.44% <0%> (+0.17%) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 92.6% <0%> (+0.48%) ⬆️
featuretools/entityset/base_entity.py 79.16% <0%> (+2.38%) ⬆️
...turetools/computational_backends/pandas_backend.py 92.07% <0%> (+2.8%) ⬆️
featuretools/synthesis/encode_features.py 98.03% <0%> (+3.49%) ⬆️
featuretools/entityset/entity.py 90.29% <0%> (+10.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a971542...d102924. Read the comment docs.

@kmax12 kmax12 changed the title from Entity unit tests to Add additional Entity unit tests May 1, 2018

@Seth-Rothschild Seth-Rothschild changed the title from Add additional Entity unit tests to (WIP) Add additional Entity unit tests May 1, 2018

@Seth-Rothschild Seth-Rothschild requested a review from rwedge May 1, 2018

@Seth-Rothschild Seth-Rothschild force-pushed the entity_unit_tests branch from 00b3505 to 4ff8c39 May 1, 2018

@Seth-Rothschild Seth-Rothschild changed the title from (WIP) Add additional Entity unit tests to Add additional Entity unit tests May 2, 2018

@Seth-Rothschild Seth-Rothschild force-pushed the entity_unit_tests branch from 4ff8c39 to d102924 May 3, 2018

@kmax12

This comment has been minimized.

Member

kmax12 commented May 7, 2018

Looks good, merging

@kmax12 kmax12 merged commit 27f48c9 into master May 7, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Seth-Rothschild Seth-Rothschild deleted the entity_unit_tests branch May 7, 2018

@rwedge rwedge referenced this pull request May 30, 2018

Merged

v0.1.21 #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment