New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tests for primitives #137

Merged
merged 4 commits into from May 3, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented May 2, 2018

There were 4 tests found that were not being run. Three had to do with symbol overrides and one was testing arithmetic on ordinals. Added functionality for adding and subtracting ordinals.

@Seth-Rothschild Seth-Rothschild force-pushed the add_old_tests branch from 9196d3e to 23fe17b May 2, 2018

@Seth-Rothschild Seth-Rothschild force-pushed the add_old_tests branch from 2c58a83 to 680d894 May 2, 2018

@codecov-io

This comment has been minimized.

codecov-io commented May 2, 2018

Codecov Report

Merging #137 into master will increase coverage by 1.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #137     +/-   ##
=========================================
+ Coverage   88.68%   90.08%   +1.4%     
=========================================
  Files          76       75      -1     
  Lines        7845     7785     -60     
=========================================
+ Hits         6957     7013     +56     
+ Misses        888      772    -116
Impacted Files Coverage Δ
.../feature_function_tests/test_transform_features.py 98.85% <100%> (+11%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.11% <0%> (-0.44%) ⬇️
featuretools/tests/utils_tests/test_config.py
featuretools/primitives/binary_transform.py 89.88% <0%> (+0.59%) ⬆️
featuretools/config.py 78.84% <0%> (+7.76%) ⬆️
featuretools/primitives/primitive_base.py 85.95% <0%> (+8.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d1a56...9fffcc8. Read the comment docs.

@kmax12 kmax12 changed the title from move return in test_arith and test_override to Add additional tests for primitives May 2, 2018

Seth-Rothschild added some commits May 2, 2018

@kmax12

This comment has been minimized.

Member

kmax12 commented May 3, 2018

Great! Merging

@kmax12 kmax12 merged commit a971542 into master May 3, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Seth-Rothschild Seth-Rothschild deleted the add_old_tests branch May 3, 2018

@rwedge rwedge referenced this pull request May 30, 2018

Merged

v0.1.21 #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment