New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the `normalize` function #140

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
4 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented May 7, 2018

@codecov-io

This comment has been minimized.

codecov-io commented May 7, 2018

Codecov Report

Merging #140 into master will decrease coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   90.73%   90.42%   -0.32%     
==========================================
  Files          76       73       -3     
  Lines        7824     7768      -56     
==========================================
- Hits         7099     7024      -75     
- Misses        725      744      +19
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 90.44% <ø> (ø) ⬆️
featuretools/entityset/entity.py 79.77% <ø> (-10.53%) ⬇️
featuretools/entityset/base_entityset.py 91.11% <100%> (-0.05%) ⬇️
featuretools/primitives/primitive_base.py 90.1% <100%> (+4.15%) ⬆️
featuretools/entityset/timedelta.py 80.71% <100%> (-0.14%) ⬇️
featuretools/entityset/base_entity.py 76.64% <100%> (-2.52%) ⬇️
featuretools/entityset/relationship.py 82.6% <100%> (-0.38%) ⬇️
featuretools/variable_types/variable.py 81.7% <100%> (+2.63%) ⬆️
featuretools/synthesis/encode_features.py 94.54% <0%> (-3.5%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f48c9...8212e55. Read the comment docs.

@kmax12

This comment has been minimized.

Member

kmax12 commented May 7, 2018

Looks good to me. Merging

@kmax12 kmax12 merged commit 8da5930 into master May 7, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Seth-Rothschild Seth-Rothschild deleted the remove-normalize branch May 8, 2018

@rwedge rwedge referenced this pull request May 30, 2018

Merged

v0.1.21 #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment