New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add names for binary #142

Merged
merged 4 commits into from May 9, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented May 8, 2018

Added names for

  • add
  • subtract
  • multiply
  • divide
  • mod
  • negate

Did not add names for the primitives built on the Compare class.

Changed weekend name to weekend instead of is_weekend so that it's easier to remember.

Seth-Rothschild added some commits May 8, 2018

@codecov-io

This comment has been minimized.

codecov-io commented May 8, 2018

Codecov Report

Merging #142 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #142      +/-   ##
=========================================
+ Coverage   91.19%   91.2%   +0.01%     
=========================================
  Files          73      73              
  Lines        7764    7767       +3     
=========================================
+ Hits         7080    7084       +4     
+ Misses        684     683       -1
Impacted Files Coverage Δ
featuretools/primitives/transform_primitive.py 97.77% <100%> (ø) ⬆️
featuretools/primitives/binary_transform.py 90.75% <100%> (+0.87%) ⬆️
.../feature_function_tests/test_transform_features.py 98.85% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a978c...dbf8509. Read the comment docs.

@kmax12 kmax12 changed the title from Names for binary to Add names for binary May 9, 2018

@Seth-Rothschild Seth-Rothschild force-pushed the names_for_binary branch from 49c44ed to 9240f92 May 9, 2018

@kmax12

This comment has been minimized.

Member

kmax12 commented May 9, 2018

Looks good to me, merging

@kmax12 kmax12 merged commit ec772a7 into master May 9, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Seth-Rothschild Seth-Rothschild deleted the names_for_binary branch May 9, 2018

@rwedge rwedge referenced this pull request May 30, 2018

Merged

v0.1.21 #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment