New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused utility functions #146

Merged
merged 4 commits into from May 10, 2018

Conversation

Projects
None yet
3 participants
@bschreck
Contributor

bschreck commented May 10, 2018

Removes:

  • utils.wrangle.flatten_2d
  • utils.wrangle._check_time_against_time

These functions were previously used, but are no longer needed

bschreck added some commits May 10, 2018

@bschreck bschreck changed the base branch from no-base-entityset-and-other-clean-ups to master May 10, 2018

@codecov-io

This comment has been minimized.

codecov-io commented May 10, 2018

Codecov Report

Merging #146 into master will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   91.37%   91.72%   +0.35%     
==========================================
  Files          72       72              
  Lines        7722     7689      -33     
==========================================
- Hits         7056     7053       -3     
+ Misses        666      636      -30
Impacted Files Coverage Δ
featuretools/utils/wrangle.py 72.64% <ø> (+15.39%) ⬆️
featuretools/utils/api.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3577d0...14e400d. Read the comment docs.

@kmax12 kmax12 changed the title from remove unused utility functions to Remove unused utility functions May 10, 2018

@kmax12

This comment has been minimized.

Member

kmax12 commented May 10, 2018

Looks good, merging!

@kmax12 kmax12 merged commit f9ab96f into master May 10, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request May 30, 2018

Merged

v0.1.21 #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment