New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename demo retail csv file #148

Merged
merged 1 commit into from May 11, 2018

Conversation

Projects
None yet
3 participants
@gsheni
Contributor

gsheni commented May 11, 2018

  • Since a new S3 link is being used, we should change the name use to save the csv to the cache.

@gsheni gsheni changed the title from fixed naming with new csv link to fixed naming with new csv May 11, 2018

@codecov-io

This comment has been minimized.

codecov-io commented May 11, 2018

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          72       72           
  Lines        7689     7689           
=======================================
  Hits         7053     7053           
  Misses        636      636
Impacted Files Coverage Δ
featuretools/demo/retail.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ab96f...670a767. Read the comment docs.

@kmax12 kmax12 changed the title from fixed naming with new csv to Rename demo retail csv file May 11, 2018

@kmax12 kmax12 merged commit aa88c53 into master May 11, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the retail_name_cache branch May 12, 2018

@rwedge rwedge referenced this pull request May 30, 2018

Merged

v0.1.21 #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment