New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more reasonable start parameter #149

Merged
merged 3 commits into from May 15, 2018

Conversation

Projects
None yet
2 participants
@bschreck
Contributor

bschreck commented May 15, 2018

In make_temporal_cutoffs, this PR allows start to be a list of times, corresponding to an associated instance id. Each one specifies the first cutoff t ime to be made for the corresponding instance.

bschreck added some commits Apr 12, 2018

@codecov-io

This comment has been minimized.

codecov-io commented May 15, 2018

Codecov Report

Merging #149 into master will decrease coverage by 1.33%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage    92.7%   91.37%   -1.34%     
==========================================
  Files          72       72              
  Lines        7693     7743      +50     
==========================================
- Hits         7132     7075      -57     
- Misses        561      668     +107
Impacted Files Coverage Δ
featuretools/utils/time_utils.py 94.44% <90%> (-5.56%) ⬇️
featuretools/tests/utils_tests/test_time_utils.py 94.28% <94.11%> (-1.37%) ⬇️
featuretools/primitives/aggregation_primitives.py 73.79% <0%> (-18.78%) ⬇️
featuretools/utils/wrangle.py 57.24% <0%> (-15.4%) ⬇️
featuretools/primitives/transform_primitive.py 86.29% <0%> (-11.49%) ⬇️
...turetools/computational_backends/pandas_backend.py 91.74% <0%> (-0.34%) ⬇️
...ols/tests/feature_function_tests/test_agg_feats.py 98.5% <0%> (-0.02%) ⬇️
.../feature_function_tests/test_transform_features.py 98.84% <0%> (-0.01%) ⬇️
featuretools/utils/api.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580c8e5...fc79076. Read the comment docs.

@bschreck bschreck merged commit 14cedde into master May 15, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@bschreck bschreck deleted the update-make-temporal-cutoffs branch May 15, 2018

@rwedge rwedge referenced this pull request May 30, 2018

Merged

v0.1.21 #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment