New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Pandas Backwards Compatibility #154

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
3 participants
@kmax12
Member

kmax12 commented May 22, 2018

Pandas 0.23.0 added a sort parameter to DataFrame.append. This PR handles the case where an old version of pandas is being used.

@kmax12 kmax12 requested a review from bschreck May 22, 2018

@codecov-io

This comment has been minimized.

codecov-io commented May 22, 2018

Codecov Report

Merging #154 into master will decrease coverage by 0.02%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   92.61%   92.59%   -0.03%     
==========================================
  Files          72       72              
  Lines        7718     7722       +4     
==========================================
+ Hits         7148     7150       +2     
- Misses        570      572       +2
Impacted Files Coverage Δ
...turetools/computational_backends/pandas_backend.py 91.55% <60%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f3045...e6f99b5. Read the comment docs.

@bschreck

This comment has been minimized.

Contributor

bschreck commented May 22, 2018

Looks good!

@bschreck bschreck merged commit ee28119 into master May 22, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request May 30, 2018

Merged

v0.1.21 #160

@kmax12 kmax12 deleted the better-pandas-23-support branch Jun 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment