New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dtypes match when adding relationship #159

Merged
merged 6 commits into from May 30, 2018

Conversation

Projects
None yet
3 participants
@rwedge
Contributor

rwedge commented May 29, 2018

Also try to convert categorical dtype to int dtype before converting it to object dtype

@rwedge rwedge requested review from bschreck and kmax12 May 29, 2018

@kmax12

This comment has been minimized.

Member

kmax12 commented May 29, 2018

Good to merge once tests pass

@codecov-io

This comment has been minimized.

codecov-io commented May 29, 2018

Codecov Report

Merging #159 into master will increase coverage by 0.39%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   92.62%   93.02%   +0.39%     
==========================================
  Files          72       72              
  Lines        7729     7741      +12     
==========================================
+ Hits         7159     7201      +42     
+ Misses        570      540      -30
Impacted Files Coverage Δ
featuretools/entityset/entity.py 91.76% <ø> (+0.96%) ⬆️
featuretools/entityset/base_entityset.py 91.3% <100%> (+0.54%) ⬆️
featuretools/tests/demo_tests/test_demo_data.py 100% <100%> (ø) ⬆️
featuretools/demo/mock_customer.py 94.73% <100%> (+73.68%) ⬆️
featuretools/tests/entityset_tests/test_es.py 98.98% <100%> (+0.08%) ⬆️
featuretools/entityset/entityset.py 90.75% <50%> (-0.66%) ⬇️
featuretools/synthesis/deep_feature_synthesis.py 92.87% <0%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1794707...8cafcdb. Read the comment docs.

rwedge added some commits May 29, 2018

@rwedge rwedge merged commit 70591f3 into master May 30, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge deleted the relationship-dtype-should-match branch May 30, 2018

@rwedge rwedge referenced this pull request May 30, 2018

Merged

v0.1.21 #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment