New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config does error checking to see if it can write to disk #162

Merged
merged 4 commits into from Jun 4, 2018

Conversation

Projects
None yet
3 participants
@bschreck
Contributor

bschreck commented Jun 4, 2018

config.py now does error checking to see if it can write to disk. Returns a fallback config dictionary with barebones entries (just logging) if reading config file from disk fails.

bschreck added some commits Jun 4, 2018

@kmax12 kmax12 changed the title from config does error checking to see if it can write to disk, and has fa… to Config does error checking to see if it can write to disk Jun 4, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Jun 4, 2018

Codecov Report

Merging #162 into master will decrease coverage by 0.13%.
The diff coverage is 36.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   93.02%   92.89%   -0.14%     
==========================================
  Files          72       72              
  Lines        7740     7753      +13     
==========================================
+ Hits         7200     7202       +2     
- Misses        540      551      +11
Impacted Files Coverage Δ
featuretools/config.py 64.58% <36.84%> (-6.51%) ⬇️
featuretools/utils/gen_utils.py 64.44% <0%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013c97f...fbd38bb. Read the comment docs.

@kmax12

This comment has been minimized.

Member

kmax12 commented Jun 4, 2018

Looks good to me!

@bschreck bschreck merged commit 47ad08c into master Jun 4, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@bschreck bschreck deleted the robust-config branch Jun 4, 2018

@rwedge rwedge referenced this pull request Jun 22, 2018

Merged

v0.2.0 #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment