New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No last time index update on normalize #169

Merged
merged 5 commits into from Jun 18, 2018

Conversation

Projects
None yet
3 participants
@rwedge
Contributor

rwedge commented Jun 18, 2018

This PR makes some changes to when last time indexes are recalculated.

  • recalculate_last_time_indexes will only recalculate if the entity had a last time index
  • Not recalculating last time index values after normalizing an entity. This can really slow down EntiySet creation. I think using EntitySet.add_last_time_indexes after getting the final EntitySet structure is simple enough.
  • During EntitySet.concat, last time indexes are updated in one go instead of when updating each entity's data.
@codecov-io

This comment has been minimized.

codecov-io commented Jun 18, 2018

Codecov Report

Merging #169 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   92.88%   92.93%   +0.05%     
==========================================
  Files          70       70              
  Lines        7486     7519      +33     
==========================================
+ Hits         6953     6988      +35     
+ Misses        533      531       -2
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 93.78% <100%> (+0.22%) ⬆️
featuretools/entityset/entity.py 85.57% <100%> (+0.24%) ⬆️
featuretools/tests/entityset_tests/test_es.py 99.76% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488c60f...fc8162d. Read the comment docs.

@kmax12 kmax12 changed the title from No lti update on normalize to No last time index update on normalize Jun 18, 2018

@kmax12

This comment has been minimized.

Member

kmax12 commented Jun 18, 2018

Looks good, merging

@kmax12 kmax12 merged commit 200d7ce into master Jun 18, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Jun 22, 2018

Merged

v0.2.0 #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment