New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move feature matrix calculation helper functions to separate file #177

Merged
merged 7 commits into from Jun 27, 2018

Conversation

Projects
None yet
3 participants
@rwedge
Contributor

rwedge commented Jun 26, 2018

calculate_feature_matrix.py has almost 800 lines of code now. This pull requests keeps calculate_feature_matrix, calculate_chunk, approximate_features, linear_calculate_chunks, and parallel_calculate_chunks in the file but moves the other functions into a separate file. This PR also moves the distributed client and cluster creation into a new helper function and adds a test case for the new helper function.

@codecov-io

This comment has been minimized.

codecov-io commented Jun 26, 2018

Codecov Report

Merging #177 into master will increase coverage by 0.09%.
The diff coverage is 95.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   93.13%   93.23%   +0.09%     
==========================================
  Files          69       70       +1     
  Lines        7688     7712      +24     
==========================================
+ Hits         7160     7190      +30     
+ Misses        528      522       -6
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 96.98% <100%> (+2.78%) ⬆️
featuretools/computational_backends/api.py 100% <100%> (ø) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.62% <100%> (ø) ⬆️
featuretools/computational_backends/utils.py 94.36% <94.36%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f224e22...8ca5dda. Read the comment docs.

@kmax12

This comment has been minimized.

Member

kmax12 commented Jun 27, 2018

Looks good!

@kmax12 kmax12 merged commit fad0dcb into master Jun 27, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Jul 2, 2018

Merged

v0.2.1 #180

@kmax12 kmax12 deleted the move-cfm-helpers-to-seperate-file branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment