New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update load flight 2 #187

Merged
merged 2 commits into from Jul 8, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented Jul 6, 2018

Docstring from load_flight needed an update to be formatted correctly, so I took the opportunity to add an example and fix a minor secondary time index problem. Here's a screenshot of how the docs page looks after the change:
image

@Seth-Rothschild Seth-Rothschild force-pushed the update-load-flight-2 branch from e819a65 to 966b796 Jul 6, 2018

@Seth-Rothschild Seth-Rothschild force-pushed the update-load-flight-2 branch from 966b796 to f202277 Jul 6, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Jul 6, 2018

Codecov Report

Merging #187 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   93.23%   93.23%   -0.01%     
==========================================
  Files          70       70              
  Lines        7712     7711       -1     
==========================================
- Hits         7190     7189       -1     
  Misses        522      522
Impacted Files Coverage Δ
featuretools/demo/flight.py 88.37% <ø> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0efa7...f202277. Read the comment docs.

@kmax12

This comment has been minimized.

Member

kmax12 commented Jul 8, 2018

looks good, merging

@kmax12 kmax12 merged commit 8cba10b into master Jul 8, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Seth-Rothschild Seth-Rothschild deleted the update-load-flight-2 branch Aug 10, 2018

@rwedge rwedge referenced this pull request Aug 20, 2018

Merged

v0.2.2 #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment