New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type checking ignore entities. #193

Merged
merged 2 commits into from Jul 22, 2018

Conversation

Projects
None yet
3 participants
@WillKoehrsen
Contributor

WillKoehrsen commented Jul 20, 2018

Addresses #192 by checking the type of ignore_entities (using isinstance) when running dfs. Passing in any type other than a list will result in a TypeError.

This is an update because the authorship on two of the commits for the previous pull request were incorrect.

@codecov-io

This comment has been minimized.

codecov-io commented Jul 20, 2018

Codecov Report

Merging #193 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
- Coverage    93.2%   93.19%   -0.01%     
==========================================
  Files          70       70              
  Lines        7715     7719       +4     
==========================================
+ Hits         7191     7194       +3     
- Misses        524      525       +1
Impacted Files Coverage Δ
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.33% <100%> (+0.01%) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 92.61% <100%> (+0.04%) ⬆️
featuretools/utils/gen_utils.py 64.44% <0%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca98aa...4e35e25. Read the comment docs.

@kmax12

This comment has been minimized.

Member

kmax12 commented Jul 22, 2018

Looks good, merging.

@kmax12 kmax12 merged commit bdcd663 into master Jul 22, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Aug 20, 2018

Merged

v0.2.2 #220

@WillKoehrsen WillKoehrsen deleted the type-checking-arguments-update branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment